On Mon, Oct 05, 2015 at 08:36:11PM +0300, Lubomir I. Ivanov wrote: > On 5 October 2015 at 20:23, Lubomir I. Ivanov <[email protected]> wrote: > > From: "Lubomir I. Ivanov" <[email protected]> > > > > Dirk, please read the comments i've made and let see if this is > portable on the other OSes as i can't test on OSX and Linux (ATM). > > with this patch the git cache files are now written exactly where the > suggested user file is (on Win32 at least). example user folder > structure: > > C:\Users\<name>\AppData\Roaming\Subsurface: > <1de30b7d6252b57e> > hashes > my_default_file.XML > > let me know if you want another patch to modify the git-access stuff > to be in sub-folder e.g. "cloudstorage"
I think that would be cleaner. > what i don't like is that default config file path and git cache thing > use different backends... > the thing is, in my opinion qthelper.cpp:system_default_directory() > should not exist and instead we should use strictly C (OS backends) to > retrieve the user paths. I am more than happy to have you rip out the Qt function here and just go back to the same C functions that we use for the default file to also give us the other paths. This obviously requires testing but I agree, having to ways to determine where stuff goes is outright silly. Thanks, Lubomir /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
