From: "Lubomir I. Ivanov" <[email protected]> The compiler complains that said static (not-inline) function in declared in the header but has no definition.
The function is only used as a helper in dive.c so so this simply acts as a forward declaration and we can safely remove it from dive.h. The same forward declaration can be in dive.c. Since dive.h is include in *many* translation units, this causes a lot instances of the same warning to be show. If the function becomes part of the API, the static keyword needs to be removed and the declaration needs to be added in the header again. Signed-off-by: Lubomir I. Ivanov <[email protected]> --- dive.h | 1 - 1 file changed, 1 deletion(-) diff --git a/dive.h b/dive.h index f039754..cef1106 100644 --- a/dive.h +++ b/dive.h @@ -721,7 +721,6 @@ extern void fixup_dc_duration(struct divecomputer *dc); extern int dive_getUniqID(struct dive *d); extern unsigned int dc_airtemp(struct divecomputer *dc); extern unsigned int dc_watertemp(struct divecomputer *dc); -static void force_fixup_dive(struct dive *d); extern int split_dive(struct dive *); extern struct dive *merge_dives(struct dive *a, struct dive *b, int offset, bool prefer_downloaded); extern struct dive *try_to_merge(struct dive *a, struct dive *b, bool prefer_downloaded); -- 1.7.11.msysgit.0 _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
