On 7 October 2015 at 14:30, Dirk Hohndel <[email protected]> wrote: > On Wed, Oct 07, 2015 at 02:27:58PM +0300, Lubomir I. Ivanov wrote: >> On 6 October 2015 at 00:27, Tomaz Canabrava <[email protected]> wrote: >> > This should fix it. >> > if not, it's a start and people that have windows should look at this patch >> > to see how it can be fixed. >> > >> >> works for Windows Vista/7 themes, but doesn't work on Windows XP >> themes, which have a dark blue background for items. >> hardcoding one of the colors is not a good solution. either all colors >> should be hardcoded or none. > > But the patch should use standard fonts on XP. I actually tested XP and it > worked. Did you test this? > >> i've tried fixing it but the highlightedText() color is returned >> white, while the background is the light blue on Windows Vista/7 >> themes. > > Broken by design. Beautiful > >> the divelist selected items looks fine on the other hand: >> - the highlight text is black >> - the background is the light blue gradient thingy >> >> so, i wonder how is the black highlightedText() text picked for divelist >> items? >> is this some sort of a QStyleOptionViewItemV4 issue... > > Well, I tried the latest daily on XP, 7 and 10 and it looks fine on all > three. I just finished downloading an 8.1 trial VM from Microsoft and will > test on that later today. >
i use a XP theme under Windows 7. hardcoding the black text would conflict with any theme that has set a darker current-selected-window color. screenshot attached. i'm trying to fix this - i.e. somehow figure out why the divelist looks fine, while this is broken. lubomir --
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
