On Mon, Nov 2, 2015 at 6:19 PM, Dirk Hohndel <[email protected]> wrote:
>
> Testing right now. It looks rather obviously correct - regardless of
> whether it fixes the bug or not. May I make up a commit message and add
> your SOB?
Just something like
Don't overflow cylinder array in xml parsing
Signed-off-by: Linus Torvalds <[email protected]>
but I do wonder if we're doing something else wrong too.
Looking (carefully - wouldn't want to go blind) at the UDDF, I see things like
<waypoint>
<depth>0</depth>
<divetime>0</divetime>
<switchmix ref="gas_25" />
<temperature>296.05</temperature>
</waypoint>
but there seems to be only one per dive (the divetime is always zero).
So I'm not quite sure what makes us overflow the cylinder thing. The
xslt translation from uddf to the native subsurface format may be
doing something odd.
So I think that xml parsing patch is worth applying regardless, but I
also get the feeling that there might be something else going on in
addition to this.
Linus
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
