On 4 December 2015 at 08:10, K. "pestophagous" Heller <[email protected]> wrote: > Signed-off-by: K. Heller <[email protected]> > --- > > This a RESUBMIT. (labeling it as such for clarity.) > > These are the same two lines I submitted on Nov 24. > > This patch held up under scrutiny in November already, see here: > http://lists.subsurface-divelog.org/pipermail/subsurface/2015-November/thread.html#23414 > > Lubomir reasonably questioned whether there is a need to patch > add_single_dive rather than fixing the call site (which indeed > is a buggy call site in the unfinished 'Add Dive' area of the > mobile app). > > I think all Lubomir's concerns are now put to rest. > Maybe you could issue an ACK, Lubomir? >
yes, i will ACK the "-1 puts a dive at the end of the list" change. BTW, the patch needs a commit message above the "signed-off line". lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
