On Sat, Jan 2, 2016 at 10:07 AM, Miika Turkia <[email protected]> wrote: > This gives the user a bit more information about the progress of setting > the cloud credentials. IMO, especially the information that the > credentials are invalid is crucial for the user experience. > > Signed-off-by: Miika Turkia <[email protected]> > --- > qt-mobile/qmlmanager.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qt-mobile/qmlmanager.cpp b/qt-mobile/qmlmanager.cpp > index 23c620e..0702b6c 100644 > --- a/qt-mobile/qmlmanager.cpp > +++ b/qt-mobile/qmlmanager.cpp > @@ -151,6 +151,7 @@ void > QMLManager::checkCredentialsAndExecute(execute_function_type execute) > { > // if the cloud credentials are present, we should try to get the GPS > Webservice ID > // and (if we haven't done so) load the dive list > + setStartPageText(tr("Testing cloud credentials")); > if (!same_string(prefs.cloud_storage_email, "") && > !same_string(prefs.cloud_storage_password, "")) { > appendTextToLog("Have credentials, let's see if they are > valid");
Or maybe having the text inside the if statement as in the attachment. miika
From ee8b32a8702081d11a36fb6bbb1070ee54560b5e Mon Sep 17 00:00:00 2001 From: Miika Turkia <[email protected]> Date: Sat, 2 Jan 2016 10:04:59 +0200 Subject: [PATCH] Give the user more information on cloud credentials This gives the user a bit more information about the progress of setting the cloud credentials. IMO, especially the information that the credentials are invalid is crucial for the user experience. Signed-off-by: Miika Turkia <[email protected]> --- qt-mobile/qmlmanager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qt-mobile/qmlmanager.cpp b/qt-mobile/qmlmanager.cpp index 23c620e..aebc65f 100644 --- a/qt-mobile/qmlmanager.cpp +++ b/qt-mobile/qmlmanager.cpp @@ -153,6 +153,7 @@ void QMLManager::checkCredentialsAndExecute(execute_function_type execute) // and (if we haven't done so) load the dive list if (!same_string(prefs.cloud_storage_email, "") && !same_string(prefs.cloud_storage_password, "")) { + setStartPageText(tr("Testing cloud credentials")); appendTextToLog("Have credentials, let's see if they are valid"); if (!mgr) mgr = new QNetworkAccessManager(this); @@ -184,7 +185,7 @@ void QMLManager::provideAuth(QNetworkReply *reply, QAuthenticator *auth) auth->password() == QString(prefs.cloud_storage_password)) { // OK, credentials have been tried and didn't work, so they are invalid appendTextToLog("Cloud credentials are invalid"); - setStartPageText(tr("No recorded dives found. You can download your dives to this device from the Subsurface cloud storage service, from your dive computer, or add them manually.")); + setStartPageText(tr("Cloud credentials are invalid")); reply->disconnect(); reply->abort(); reply->deleteLater(); -- 2.5.0
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
