On Monday, January 25, 2016 06:44:50 PM Joakim Bygdell wrote:
> After adding "Cylinder" to the DiveDetails page the objects had to be
> rearranged in order to better utilise the space.
> To get a cleaner look on smaller screens the left side is left aligned and
> the right side is right aligend.

I don't really like that alignment change. The labels are aligned to the right 
as to make the label closely connected to the values they correspond to. The 
problem with left aligning is that if only one label in a given column is long 
(which can happen easily with translations to Russian, Finnish or German), the 
values and labels get more disconnected. Putting them closer together makes it 
easier to read.
The "it looks better" is purely a matter of taste however. The only measurable 
thing here is "how many virtual alignment lines do we create", and that hasn't 
changed.

The other patches look good from a cursory look, useful stuff in there!

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to