On Mon, Feb 01, 2016 at 09:28:53PM +0200, Willem Ferguson wrote: > Subject: [PATCH 3/3] [PATCH] Mobile. Update downloadfromdivecomputer screen. > > 1) Insert spacer to make space for silly button at screen bottom. > 2) Adjust column widths of table of downloaded dives. > 3) Simplification and general cleanup of QML code for this page. > > Signed-off-by: Willem Ferguson <[email protected]> > > I attach a screenshot of what it looks like on my computer. > Kind regards, > willem >
> From e4a827f86526c752a4c42d8517ff8b25adca6bb1 Mon Sep 17 00:00:00 2001 > From: Willem Ferguson <[email protected]> > Date: Mon, 1 Feb 2016 21:07:36 +0200 > Subject: [PATCH 3/3] [PATCH] Mobile. Update downloadfromdivecomputer screen. > > Insert spacer to make space for silly button. > Adjust column widths of table. > General cleanup of QML code for this page. > > Signed-off-by: Willem Ferguson <[email protected]> > --- > qt-mobile/qml/DownloadFromDiveComputer.qml | 206 > ++++++++++++++--------------- > 1 file changed, 101 insertions(+), 105 deletions(-) > > diff --git a/qt-mobile/qml/DownloadFromDiveComputer.qml > b/qt-mobile/qml/DownloadFromDiveComputer.qml > index d18c37b..3fa95b3 100644 > --- a/qt-mobile/qml/DownloadFromDiveComputer.qml > +++ b/qt-mobile/qml/DownloadFromDiveComputer.qml > @@ -1,118 +1,114 @@ > import QtQuick 2.3 > import QtQuick.Controls 1.2 > +import QtQuick.Controls.Styles 1.2 > import QtQuick.Window 2.2 > import QtQuick.Dialogs 1.2 > import QtQuick.Layouts 1.1 > import org.subsurfacedivelog.mobile 1.0 > > Item { > - id: diveComputerDownloadWindow > - anchors.top: parent.top > - width: parent.width > - height: parent.height > + id: diveComputerDownloadWindow > + anchors.top:parent.top > + width: parent.width > + height: parent.height > + Layout.fillWidth: true; Whitespace :-( I really can't tell easily what you changed. It's usually a good idea to take a look at your patch before you send it and ask yourself... "are these the changes that I made, or is something else going on"? /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
