That's what I guessed before having to run. Please submit upstream /D
-- Sent from my phone > On Feb 5, 2016, at 14:39, Rick Walsh <[email protected]> wrote: > > > >> On 6 February 2016 at 09:15, Rick Walsh <[email protected]> wrote: >> >> >>> On 6 February 2016 at 09:10, Dirk Hohndel <[email protected]> wrote: >>> On Sat, Feb 06, 2016 at 08:57:49AM +1100, Rick Walsh wrote: >>> > On 6 February 2016 at 08:48, Dirk Hohndel <[email protected]> wrote: >>> > >>> > > On Sat, Feb 06, 2016 at 07:40:35AM +1100, Rick Walsh wrote: >>> > > > >>> > > > It does have the bug where you need to press edit a dozen times before >>> > > you >>> > > > can edit a dive. >>> > > >>> > > I hate Heisenbugs. So I modified the mobile components to print out >>> > > debug >>> > > information whenever the ActionButton is tapped. And of course with that >>> > > in place it always works, reliably, on the first attempt :-( >>> > > >>> > > I have now added this to the next official build just to see if this is >>> > > just a fluke here or if this really fixes things for everyone. Same >>> > > visible version number (as this is a change to the mobile components). >>> > > Please re-download >>> > > downloads/daily/Subsurface-mobile-4.5.2.774-Qt5.5.arm.apk >>> > > and test if the "press edit takes many many attempts" still happens for >>> > > you. If it does, I'd love to see the logcat output... >>> > > >>> > >>> > You're easily pleased. On first try it took 15 attempts to press the >>> > button >>> >>> Now I'm confused again. What else is new. Next attempt. Can you download >>> the latest one and try (stupidly still with the same filename - sorry) >> >> Worked first time, and several times in a row after that. >> >> D/Subsurface(16684): >> qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:87 >> (onClicked): qml: ActionButton clicked QQuickAction(0xdb34f0a0)function() { >> [code] } >> D/Subsurface(16684): >> qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:99 >> (onClicked): qml: triggering action >> W/Subsurface(16684): (null):0 ((null)): Could not resolve property : >> linearGradient4538 >> W/Subsurface(16684): (null):0 ((null)): Could not resolve property : >> linearGradient4588 >> >> Rick > > > I'm not sure if you've already worked out what I just did, but I added a > little debug output myself to find out where the (mouse.x < buttonGraphics.x > || mouse.x > buttonGraphics.x + buttonGraphics.width) condition was going > wrong. > > D/Subsurface(24634): > qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:88 > (onClicked): qml: outside zone - mouse.x: 719 ; buttonGraphics.x: 738 ; > buttonGraphics.width: 114 > D/Subsurface(24634): > qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:88 > (onClicked): qml: outside zone - mouse.x: 680 ; buttonGraphics.x: 738 ; > buttonGraphics.width: 114 > D/Subsurface(24634): > qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:88 > (onClicked): qml: outside zone - mouse.x: 721 ; buttonGraphics.x: 738 ; > buttonGraphics.width: 114 > D/Subsurface(24634): > qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:88 > (onClicked): qml: outside zone - mouse.x: 693 ; buttonGraphics.x: 738 ; > buttonGraphics.width: 114 > D/Subsurface(24634): > qrc:////imports/org/kde/plasma/mobilecomponents/private/ActionButton.qml:91 > (onClicked): qml: within zone - mouse.x: 757 ; buttonGraphics.x: 738 ; > buttonGraphics.width: 114 > > It appears that the button is centre aligned, so buttonGraphics.x relates to > the middle of the button. Click just to the left of the centre and it fails, > click just to the right and it works. > > I've fixed the problem with this little change: > > $ diff ../subsurface/qt-mobile/qml/mobilecomponents/private/ActionButton.qml > components/mobilecomponents/qml/private/ActionButton.qml > 87c87 > < if (mouse.x < buttonGraphics.x - buttonGraphics.width / 2 || > mouse.x > buttonGraphics.x + buttonGraphics.width / 2) { > --- > > if (mouse.x < buttonGraphics.x || mouse.x > buttonGraphics.x + > > buttonGraphics.width) { > > > Did you come to the same conclusion? I'm guessing you've already worked out a > solution, but if not and you think that's correct, I'll submit that upstream. > > Rick > >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
