On Wednesday, February 10, 2016 07:50:00 PM Miika Turkia wrote: > On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler <[email protected]> wrote: > > On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote: > >> +import QtQuick.Window 2.2 > >> +import QtQuick.Dialogs 1.2 > > > > Seems unused? > > > >> + signal accept > > > > What is this used for? > > I am quite clueless when it comes to QML so I am quite sure these can > be removed. Some leftover from the Preferences.qml that I used as > starting point.
That's what we have reviews for. I see it not only as a way of making sure we keep code quality high, but also as a way of spreading knowledge -- I don't want to be the only one knowing this stuff, as to reduce the bus numer. -- sebas http://www.kde.org | http://vizZzion.org _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
