On Sun, Feb 14, 2016 at 08:48:48AM +0100, Joakim Bygdell wrote:
> Issues found:
> Cloud credentials page:
> If you have valid cloud credentials in place it is not possible to go back to 
> the divelist,
> pressing the action button does nothing and the back button closes the app.
> You can’t go back by selecting “Dive list” in the menu either.

You compiled from source and didn't use my APK. Use the attched patch for
plasma-mobile to make the back button work.

> Selecting sub-menues does not close the lefthand drawer, 
> the page is loaded in the background and the drawer is returned to the top 
> level listings.
> * Show GPS fixes
> * App log
> * Divelist
> * Add dive

That is NOT the case for me with the pre-compiled APK. Is your copy of
plasma-mobile current?

> Canceling the Add dive does not show you the divelist, but the details page 
> of the last dive in the list.

That is indeed a bug. Oops. Will fix.

/D
>From 8381291d8b82a815691290bb75fe6cba3b4e08c0 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel <[email protected]>
Date: Sat, 13 Feb 2016 21:00:13 -0800
Subject: [PATCH 3/3] Allow the app to filter the back key even at the top
 level

There's no reason why the application shouldn't be able to prevent the
user from exiting with the back key.

Signed-off-by: Dirk Hohndel <[email protected]>
---
 components/mobilecomponents/qml/ApplicationWindow.qml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/components/mobilecomponents/qml/ApplicationWindow.qml b/components/mobilecomponents/qml/ApplicationWindow.qml
index ff6b1618a55e..1ed25e6dc640 100644
--- a/components/mobilecomponents/qml/ApplicationWindow.qml
+++ b/components/mobilecomponents/qml/ApplicationWindow.qml
@@ -72,11 +72,15 @@ ApplicationWindow {
                     root.contextDrawer.close();
                 } else if (root.globalDrawer && root.globalDrawer.opened) {
                     root.globalDrawer.close();
-                } else if (__pageStack.depth > 1) {
+                } else if (__pageStack.depth >= 1) {
                     var backEvent = {accepted: false}
                     __pageStack.lastVisiblePage.backRequested(backEvent);
                     if (!backEvent.accepted) {
-                        __pageStack.pop();
+                        if (__pageStack.depth > 1) {
+                            __pageStack.pop();
+                        } else {
+                            Qt.quit();
+                        }
                     }
                 } else {
                     Qt.quit();
-- 
2.7.0

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to