this cleans the CMakeLists file (it reverts to master) and removes some
noise on the dumb project for iOS.


On Sat, Mar 5, 2016 at 2:01 PM, Tomaz Canabrava <[email protected]> wrote:

>
>
> On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel <[email protected]> wrote:
>
>> Sadly the patches are base64 encoded (typical Mac issue) and I can't
>> easily quote them in there.
>>
>> A few comments:
>>
>> If you don't use cmake, why patches to the CMakeLists.txt file? That seems
>> to make no sense (oh, and it's whitespace damaged, too)
>> There are also changes to the CMakeLists.txt files in subdirectories.
>>
>> subsurface-ios/Mainform.ui.qml
>> subsurface-ios/main.qml
>> subsurface-ios/qml.qrc
>>
>> What is that used for?
>>
>
> Forgot to clean. Will send a new patch in a bit, sorry for the noise.
> The CMake was part of the squash (I forgot about it, but I think I can
> easily checkout the CMake from master)
>
>
>>
>>
>> The include file cleanups could easily be their own patch I think.
>>
>
>
>
>>
>> /D
>>
>
>

Attachment: 0003-Remove-leftovers-from-the-other-trials-for-iOS-build.patch
Description: Binary data

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to