Thanks, Robert.
I have a couple of small concerns. Given that it's past midnight in
Germany, I'll just fix them in your commit
/D
> diff --git a/desktop-widgets/diveplanner.cpp b/desktop-widgets/diveplanner.cpp
> index e6fe612..32797f0 100644
> --- a/desktop-widgets/diveplanner.cpp
> +++ b/desktop-widgets/diveplanner.cpp
> @@ -448,6 +447,18 @@ void PlannerSettingsWidget::settingsChanged()
> ui.bottomSAC->setValue((double) prefs.bottomsac / 1000.0);
> ui.decoStopSAC->setValue((double) prefs.decosac / 1000.0);
> }
> + if(get_units()->pressure == units::BAR) {
> + ui.reserve_gas->setSuffix(tr("bar"));
> + ui.reserve_gas->setSingleStep(1);
> + ui.reserve_gas->setMaximum(5000);
step of 1 makes sense, a maximum of 5000 bar makes no sense. We used to
allow up to 99bar here - I think we should keep that, or make it an even
100.
> + ui.reserve_gas->setValue(prefs.reserve_gas / 1000);
> + } else {
> + ui.reserve_gas->setSuffix(tr("psi"));
> + ui.reserve_gas->setSingleStep(1);
Step of 1psi? I don't think so. Let's make that 10.
> + ui.reserve_gas->setMaximum(5000);
5000 psi reserve? How about 1500? Which is similar to the 100bar above.
/D
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
