On Mon, May 16, 2016 at 09:12:13PM +0200, Joakim Bygdell wrote: > > > On 16 May 2016, at 20:39, Dirk Hohndel <[email protected]> wrote: > > > > On Mon, May 16, 2016 at 11:17:22AM -0700, Dirk Hohndel wrote: > >> On Sat, May 07, 2016 at 02:33:50PM +0200, Joakim Bygdell wrote: > >>> When running Subsurface-mobile on my laptop > >>> I have a fully functional combobox that autocompletes text input > >>> based on what exists in the list model. > >>> > >>> However when I run the same build on android > >>> the autocompletion only works for elements in the list that start with > >>> numbers. > >>> > >>> First I thought that the text auto suggestion from the keyboard was to > >>> blame > >>> but I have the same issue when I disable that via > >>> inputMethodHints: Qt.ImhNoPredictiveText > >>> > >>> > >>> I could find one bug report that autocompletion didn’t work on android > >>> but that should have been fixed for Qt 5.6. > >> > >> It's very obvious that Android and iOS are second class platforms for Qt. > >> I just applied your patches and will test them in a minute... but it's > >> entirely possible that you are finding actual bugs... > > > > Right now adding a dive is broken. There's the obvious issue that main.qml > > refers to buddy, suit and divemaster which all three no longer exist as > > properties (easy to fix), but even if you fix that, the auto completion on > > each of the three items simply shows a '0' in the combo box > Interesting, that means that the helper function wasn’t run when dive edit is > activated via > the add dive function. As a zero in the combobox means that the list model is > empty.
Yes - main.qml can start edit mode as well (in order to add dives), and you only changed DiveDetails.qml to make the change... Can you send a follow up patch that addresses that? And thank you for your contribution. I know this was a massive pain to get working and really appreciate that you stuck with it and figured it out. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
