Rick, > Am 06.07.2016 um 14:40 schrieb Rick Walsh <[email protected]>: > > The first patch in this series changes the divedatapoint structure to include > the cylinder index instead of the gasmix. This requires a number of changes, > but simplifies the planner code overall and makes it easier to manage > modifying multiple cylinders without model getting lost. The third patch > takes advantage of this and fixes #970 (update cylinder deco MOD when the > deco pO2 is changed). > > The remaining patches are reworked from my previous series improving handling > of "best mixes", taking into consideration feedback from Robert and Anton.
I still haven’t had the proper time to carefully read through all your patches. But since Dirk has them applied, I played around a bit with them and all looks very nice. I only have two questions or remarks: What exactly does the MND column display/mean? It seems, for air it’s always 30m (which, as I understand is the MND that GUE divers aim for). It seems to me, the meaning is something like „what would be the MND of this dive if the depth were 30m?“. Is that impression correct? Shouldn’t it rather show the MND at the max depth? So it would always be max depth if the gas is air? My other remark is about the renaming of the „Switch at“ column to „Deco MOD“. I am not sure it is the best possible name. It suggests (at least to me) that it is the same as the „Bottom MOD“ column, just for the other max ppO2 value. But it is not. Its meaning is that the planner changes to that gas at the given depth. It is initialized with the MOD but when the user changes it it does not mean that this implicitly changes the gas to adopt the new MOD, it only tells the planner to switch to that gas at a different depth. Thus I kind of liked the old name better. But please convince me otherwise. Maybe my problem is also that I am not sure what the most common use case of a user entering a MOD (for subsurface to figure out the best mix) would be. Would she expect that to be a bottom gas or a deco gas? Should we try to be clever about this (e.g. only treat the gas with the lest O2 content as bottom gas or maybe something else)? Of course, when a software is too clever it is confusing for the user what it actually does. I don’t know. Best Robert
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
