On Tue, Nov 1, 2016 at 3:25 PM, Tomaz Canabrava <[email protected]> wrote:

> more fixes regarding preferences
>
> On Tue, Nov 1, 2016 at 2:46 PM, Tomaz Canabrava <[email protected]>
> wrote:
>
>>  bugfixes regarding preferences
>>
>> still checking for more.
>> (the font issue that willem said is fixed on this series)
>>
>> Tomaz
>>
>> On Tue, Nov 1, 2016 at 12:06 PM, Tomaz Canabrava <[email protected]>
>> wrote:
>>
>>> FINALLY
>>> this finishes the unittests - sorry for all delays.
>>>
>>> I'll now look for misbehaving preferences, like the one willan
>>> complained.
>>>
>>> Tomaz
>>>
>>
>>
>
From c1fbcc557aeb6a631cc6361769d3e6dd9c4aab24 Mon Sep 17 00:00:00 2001
From: Tomaz Canabrava <[email protected]>
Date: Tue, 1 Nov 2016 15:44:30 +0100
Subject: [PATCH 13/13] Misc fixes

Remove a few uneeded lines and add more loading code for
the preferences.

Signed-off-by: Tomaz Canabrava <[email protected]>
---
 core/subsurface-qt/SettingsObjectWrapper.cpp | 2 ++
 desktop-widgets/subsurfacewebservices.cpp    | 2 --
 profile-widget/diveprofileitem.cpp           | 2 --
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/core/subsurface-qt/SettingsObjectWrapper.cpp b/core/subsurface-qt/SettingsObjectWrapper.cpp
index 68fdf19..60efe9a 100644
--- a/core/subsurface-qt/SettingsObjectWrapper.cpp
+++ b/core/subsurface-qt/SettingsObjectWrapper.cpp
@@ -2296,6 +2296,8 @@ void SettingsObjectWrapper::load()
 	GET_TXT("time_format", time_format);
 	GET_TXT("date_format", date_format);
 	GET_TXT("date_format_short", date_format_short);
+	GET_BOOL("time_format_override", time_format_override);
+	GET_BOOL("date_format_override", date_format_override);
 	s.endGroup();
 }
 
diff --git a/desktop-widgets/subsurfacewebservices.cpp b/desktop-widgets/subsurfacewebservices.cpp
index 312e823..15a1496 100644
--- a/desktop-widgets/subsurfacewebservices.cpp
+++ b/desktop-widgets/subsurfacewebservices.cpp
@@ -380,8 +380,6 @@ void WebServices::resetState()
 
 SubsurfaceWebServices::SubsurfaceWebServices(QWidget *parent, Qt::WindowFlags f) : WebServices(parent, f)
 {
-	QSettings s;
-
 	// figure out if we know (or can determine) the user's web service userid
 	QString userid(prefs.userid);
 
diff --git a/profile-widget/diveprofileitem.cpp b/profile-widget/diveprofileitem.cpp
index 2400320..c3c7165 100644
--- a/profile-widget/diveprofileitem.cpp
+++ b/profile-widget/diveprofileitem.cpp
@@ -14,8 +14,6 @@
 #include "libdivecomputer/parser.h"
 #include "profile-widget/profilewidget2.h"
 
-#include <QSettings>
-
 AbstractProfilePolygonItem::AbstractProfilePolygonItem() : QObject(), QGraphicsPolygonItem(), hAxis(NULL), vAxis(NULL), dataModel(NULL), hDataColumn(-1), vDataColumn(-1)
 {
 	setCacheMode(DeviceCoordinateCache);
-- 
2.10.2

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to