On 06 February, 2017 - Cristian Ionescu-Idbohrn wrote:

> On Mon, 6 Feb 2017, Anton Lundin wrote:
> > 
> > Signed-off-by: Anton Lundin <[email protected]>
> > ---
> >  packaging/android/android-build-wrapper.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/packaging/android/android-build-wrapper.sh 
> > b/packaging/android/android-build-wrapper.sh
> > index c1afcfb..03e4d5c 100644
> > --- a/packaging/android/android-build-wrapper.sh
> > +++ b/packaging/android/android-build-wrapper.sh
> > @@ -35,7 +35,7 @@ fi
> >  
> >  # make sure we have the required commands installed
> >  MISSING=""
> > -for i in git cmake autoconf libtool java ant; do
> > +for i in git cmake autoconf libtool java ant wget; do
> >     which $i > /dev/null 2>&1 ||
> 
> Much better to use `command' (shell builtin and available in all POSIX 
> complient shells), instead of `which' (fork and possible not available 
> on all distributions):
> 
>       command -v $i >/dev/null $$
> 
> >             if [ "$i" = "libtool" ] ; then
>                    ^  ^   ^       ^
> No quotes needed.
> 

I blame Dirk for those =)

Feel free to send patches!


//Anton


-- 
Anton Lundin    +46702-161604
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to