Linus,

> On 08 Feb 2017, at 21:31, Linus Torvalds <[email protected]> 
> wrote:
> 
> Yeah, it looked to me that everything that that code was doing was now
> handled automatically by the improved cylinder merging code.
> 
> So I _think_ it all works, but somebody who actually uses the planner
> should very much check.

from what I see, in the matching you only look at the gas percentages but not 
at the content (start/end pressures and sizes). In Willem’s case that wouldn’t 
be good enough. I would say, don’t merge cylinders if both have start and end 
pressures and they differ. And in merging don’t overwrite valid start/end 
pressures by zero.

Best
Robert

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to