On Sun, Feb 26, 2017 at 08:43:40AM -0800, Dirk Hohndel wrote: > On Sun, Feb 26, 2017 at 02:29:12PM +0100, Robert Helling wrote: > > Dirk, > > > > > On 26 Feb 2017, at 06:22, Dirk Hohndel <[email protected]> wrote: > > > > > > Please let me know what you think... > > > > except for dereferencing a potentially NULL current_dive (see my comment on > > github) this looks good and safe to me. > > Good catch! So you've played with this, no negative effects on the > planner? Good. > > Anyone else? > > I still don't feel comfortable adding this to 4.6.3 right now, but maybe > that will get delayed? I'll need to check progress on the translations, I > guess. > > If a few more people could try this and speak up, I'd really appreciate > it.
I just pushed a new version that fixes the bug that Robert found and adds another commit that makes it behave better when adding dives to an empty repo. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
