On 6 March 2017 at 17:32, Stefan Fuchs <[email protected]> wrote: > Hallo Dirk, > Am 06.03.2017 um 06:41 schrieb Dirk Hohndel: > > How is this progressing? Since I have started to pull new features maybe > this should get merged as well? > Or is it still too early for that? > > This is the status: > Implementation and review: Code unchanged since a few days. No known > issues. Review once done by Robert. > Testing: Only by me. No feedback yet from Rick, Pablo,... >
Sorry for being so slow to do any testing and provide feedback. In my limited testing, I have verified that it works and produces expected results. On the UI side, I'd consider taking the SAC factor and Problem solving time preferences out of Gas options, and creating a new group below called Minimum gas calculation. But if you'd prefer not to, it's still an ACK from me. > Documentation: Not yet but I can write s.th. for the user manual during > the next days. > In the manual entry, it might be worth acknowledging that there are many ways to calculate minimum gas, and this is just one. For instance, GUE advocate adopting a slower ascent rate of 3m/min, compared to 9m/min used for planning. This is almost equivalent to tripling the SAC factor that would otherwise be used; the difference being that it then triples the problem solving gas use. > Automated tests: Not yet. > > > Best regards > Stefan > > -- > > Stefan Fuchs > E-Mail: [email protected] > > _______________________________________________ > subsurface mailing list > [email protected] > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
