btw, finally managed to work on it a bit, i do actually get a strange bug when clicking on a dive in the list for the second time, which may indeed be a bug in kirigami. I am investigating into it, so far i have several fixes in subsurface that make editing a dive/creating one work again, alongside an (almost) complete port to QtQuickcontrols2. When i figured out and fixed that problem, I'll post here the patch.
On Friday 24 March 2017 20:46:49 Dirk Hohndel wrote: > Just for the record, your patch does make it better for me as well. > > -- > From my phone > > > -------- Original Message -------- > From: Jan Mulder <[email protected]> > Sent: Fri Mar 24 16:15:24 PDT 2017 > To: Rick Walsh <[email protected]>, Dirk Hohndel <[email protected]> > Cc: Subsurface Mailing List <[email protected]> > Subject: Re: trying to make progress with Subsurface-mobile > > On 24-03-17 21:54, Rick Walsh wrote: > > On 25 Mar. 2017 6:48 am, "Dirk Hohndel" <[email protected] > > > > <mailto:[email protected]>> wrote: > >> On Mar 24, 2017, at 8:43 AM, Dirk Hohndel <[email protected] > >> > >> <mailto:[email protected]>> wrote: > >>> On Mar 24, 2017, at 2:59 AM, Jan Mulder <[email protected] > >>> > >>> <mailto:[email protected]>> wrote: > >>>> A couple of small but annoying bugs I noticed: > >>>> In editing dive notes, the Android keyboard never automatically > >>>> capitalizes the first letter of a sentence. In other apps it > >>>> does. Not sure if this can be changed in qml. > >>>> > >>>> The back button from the gps preferences (possibly some other > >>>> pages too) doesn't work. Hit it a second time and the app closes. > >>> > >>> It is really weird that I can reproduce these issues, and Rick > >>> can not. I suspect some timing issues involved, as I am testing > >>> on a phone that less powerful than Rick uses. > > > > Samsung kindly replaced my phone under warranty this week, so now > > testing on a galaxy s7, which is a bit more powerful. > > > >> That whole bug is really strange and I still am trying to create > >> a smaller test case to make it easier for Marco to reproduce our > >> problem :-( > > > > OK, a new daily is available for Android under downloads/daily - I > > will try to get something up for iOS as well (as usual, waiting > > for things to process / review / whatever takes longer). > > > > The one bug I still can reproduce is the long hang (which on lower > > mem phones might still cause crashes): select a few dives from the > > top, going earlier and earlier. Then select one about 5 dives > > before the last one that you selected. Takes about a minute to > > display - so I'm guessing we are once again rendering ALL of the > > dives :-( > > > > I was just about to write that I couldn't reproduce the bug. But now I > > can. I selected several dives near the top. Then several quite a bit > > further down. When selecting one in between the app hung for a little > > while, but didn't crash. > > > > Oh, and just now I managed to get it to not show the same dive > > when rotating. > > > > I can definitely reproduce that one. > > > > So I'd say this is a clear improvement, but not perfect, yet. > > My votes for the 4.6.3.151 (from the play store): > - can't reproduce the enumerate issue with both Dirks and Ricks procedure > - can't reproduce the "different dive when rotating". > > It is getting more and more strange ... somehow I'm happy that I can't > reproduce (so I did sufficient testing before sending the "fix"), but on > the other side very unhappy on the seemingly non deterministic nature of > the issues at hand. > > best, > > --jan -- Marco Martin _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
