On Fri, Mar 31, 2017 at 02:23:21PM +0200, Marco Martin wrote: > Hi all, > > as promised, this patch makes the dive edits view fully functional again and > ports most of the things to QtQuickcontrols2 (advantage is that it would look > way more at home with android material apps
Cool. > some issues: > * combobox in the edit view is still not ported, it's a bit tricky with qqc2 > comboboxes as they are not editable. however, it seemed it wasn't really > semantically a combobox, rather a textfield that used the combo for typing > suggestions? that could be reimplmented easily with a textfiled that has an > internal listview for displaying suggestions Yes - that's pretty much what it is. I don't think I know how to implement that. Can you point me at a starting point... > * downloadfromdivecomputer.qml is not ported, as it didn't seem to be used at > all in the app? Willem is working on implementing that, but got stalled. I'm sure that he would love some pointers to get that part going. > * StyledTextField and subsurfacebutton components would go, making code a bit > simpler (in qqc2 they are styled more android-like, is still possible to > write > a text field styled completely different, if needed) I'm not quite sure what you mean by that... > screenshot: http://imgur.com/a/yX6Kb Looks good! I will aplly the patch, pull the latest Kirigami and try to create some test builds. Again, thank you so much for looking into this. We owe you. Again, /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
