On segunda-feira, 17 de abril de 2017 14:41:13 PDT Lubomir I. Ivanov wrote: > On 18 April 2017 at 00:18, Thiago Macieira <thi...@macieira.org> wrote: > > On segunda-feira, 17 de abril de 2017 14:10:28 PDT Lubomir I. Ivanov wrote: > >> i guess we could just do a: > >> void MarbleDebug::setEnabled(bool enabled) > >> { > >> > >> Marble::loggingCategory.setEnabled(enabled); > >> MarbleDebug::m_enabled = enabled; > >> > >> } > > > > I'd go a little further and drop the m_enabled variable completely. You > > don't need it, let the bit in the QLoggingCategory variable keep the > > state. > > > > You'd have: > > > > namespace MarbleDebug { > > Q_LOGGING_CATEGORY(category, "marble", QtWarningMsg) > > > > void setEnabled(bool enabled) > > { > > > > category.setEnabled(QtDebugMsg, enabled); > > > > } > > > > bool isEnabled() // do you even need this function? > > { > > > > return category.isDebugEnabled(); > > > > } > > } //namespace MarbleDebug > > > > This changes to the MarbleDebug namespace too. > > thanks, i think i understand. > > here are the updated Marble files and a patch diff for review. > i can't build Marble to test these changes ATM though.
Looks good, so long as "Marble::category" isn't too generic a name. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface