I'm way behind on looking at stuff. I may find time tomorrow, definitely next week on the dive trip.
/D -- >From my phone -------- Original Message -------- From: "Lubomir I. Ivanov" <[email protected]> Sent: Sat Jun 10 13:30:39 PDT 2017 To: Linus Torvalds <[email protected]> Cc: Subsurface Mailing List <[email protected]>, Dirk Hohndel <[email protected]> Subject: Re: Github issue 412: lbs values On 10 June 2017 at 23:13, Linus Torvalds <[email protected]> wrote: > On Sat, Jun 10, 2017 at 12:49 PM, Lubomir I. Ivanov <[email protected]> > wrote: >> >> perhaps both the lrint() calls should be removed and let QString() >> with 'f' (0/1) handle that? > > Agfreed. The whole "lbs = lrint(lbs + 0.05);" thing isn't even a > sensible thing to do in the first place, and the other version (that > adds half a lbs) is confused too, since lrint() already rounds. > > So ack on your patch. > attached is the signed-off patch with a commit message. maybe Dirk can confirm if we need to handle it differently. lubomir --
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
