Stupid question :S Applied it in the libdivecomputer directory with -p1 Libdivecomputer seems to build correctly. I'm building the entire Subsurface project now and will report back after that.
Benjamin On 28 June 2017 at 23:02, Benjamin <[email protected]> wrote: > Where exactly do I apply the patch file? In the Subsurface directory? > > On 28 June 2017 at 22:33, Linus Torvalds <[email protected]> > wrote: > >> On Wed, Jun 28, 2017 at 9:42 AM, Benjamin <[email protected]> wrote: >> > Good afternoon >> > I'm running macos 10.12.5. >> > I just synced to the latest sources, and when running the build script, >> I >> > get the following message: >> > >> > Making install in src >> > >> > CCLD libdivecomputer.la >> > >> > Undefined symbols for architecture x86_64: >> > >> > "_crc32", referenced from: >> >> Interesting. The new Suunto protocol over bluetooth needs crc32() for >> stream integrity control, and I was expecting to get it from zlib - >> which we require to be there anyway due to other dependencies (eg >> libgit uses zlib too). >> >> An you must have zlib installed *somehow*, since the >> >> #include <zlib.h> >> >> in suunto_eonsteel.c worked. >> >> I wonder what the difference here between macos and Linux is - maybe >> it's a clang linker difference, or maybe I got crc32() some other >> way.. >> >> Anyway, it definitely is my bug - I think I just added the "-lz" to >> the wrong place (I hate autotools, and I'm bad at it). >> >> I think the attached trivial patch to move the -lz to the right place >> will fix it. Can you please test? >> >> Linus >> > >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
