On 23 July 2017 at 16:19, Dirk Hohndel <[email protected]> wrote: > > On Jul 22, 2017, at 10:39 PM, Joakim Bygdell <[email protected]> wrote: > >> >> Activating the GPS service should not be under settings. This is not a >> service setting: it is an action just as "Manual sync with cloud" is an >> action. At the very least it should be in the GPS submenu and not in >> Settings. Then again, there is under "Dive Management, the option "Enable >> auto cloud sync". Is this a setting? It turns out these distinctions are >> actually not black and white. >> > > No they are not and we should define where the ambiguous parts should > belong. > > > I really liked having the GPS service at the top level - to make sure it's > visible that it's on (it drains the battery - not a lot, but some). > > > >> >> I have two proposals for "Run location service" activation. 1) Move the >> "Run location service" switch to the GPS submenu and indicate whether it >> is active or inactive by an appropriate icon on the left, indicating on or >> off. I could help with icons but Joakim has been so efficient with his >> icons I would prefer him do this. 2) For the location service to be useful >> at all, the user must be able to easily see whether it is active or not, >> even on the main menu. This is why the previous arrangement with a checkbox >> on the main menu was very useful. Is it possible to have an icon in the >> Android icon bar at the top of the screen? >> > > 1) Moving it to the GPS menu is no problem, the icon on the other hand... > If we add a icon to show that the GPS is off, that would be the default > view for most people, see picture. > > what we really should do is to interact with the OS backend and display > the GPS icon in the top bar just like Google Maps does when active. > > > That's totally non-obvious to me. I always thought that was a poor choice > on Google's part. > > Or we could apply an color the the GPS icon in the drawer when the service > is active, that way it will be REALLY clear when it is active or not. > > > THAT I like. Make the icon gray like all the other ones when not active, > and accent color when active. >
Looks like Kirigami prevent us from doing that, can't assign color to a Action element. And since all images are of type svg, whatever color they are initially doesn't matter. > > /D > > -- Jocke
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
