On Wed, Jul 26, 2017 at 09:57:27PM -0700, Linus Torvalds wrote: > Anyway, without further ado, here's the patch. No sign-off yet, because I > do think people should look and comment. But I think the patch is fine, > and I'll fix anythign that anybody can find, *except* for that TankItem > thing that I will refuse to touch. That class is ugly. It needs to have > access to the actual dive.
OK, I finished a first read through the patch. It's not as scary as I feared, but there are a couple of functions I want to spend more time on. So far nothing stood out as exceptionally stupid. I think the main other people from whom I'd love to see a review are Robert and Anton... /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
