On 27 July, 2017 - Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 12:43 PM, Linus Torvalds > <[email protected]> wrote: > > > > Also, there are a few things that never worked and that I'd like to > > make work, like just making the "Info window" show all the pressures > > that we're tracking at that point. Right now it only shows the first > > cylinder in the info window. > > Oh, and the momentary SAC rate calculations are another example of "it > used to be simple when we only had one pressure at a time" and will > need some fixup to actually do the right thing. > > So "small details" like that - not directly related to this patch, but > related to the fact that we have more/different information.
On the subject of SAC rate, when we interpolate the SAC between a start and end pressure, we currently do that on _pressure_, as pressure_time. Since you made our gas volume calculations more correct, Ie factor for the non linearity of gases, we now get a pretty odd momentary SAC in the info box. If you open dives/sac-test.xml , you will see that the SAC value in the info box rises during the dive, as the pressure drop in the cylinder. I understand why, but this would be really confusing for a end user. We should interpolate with volume from the cylinder, not pressure, so we get a constant SAC. Its going to be some extra calculations, but I don't think its going to be that hard. It's on my TODO-list, but maybe you would like to tackle it as you're currently working with that code. //Anton -- Anton Lundin +46702-161604 _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
