On Thursday, 30 August 2018 23:01:20 CEST Berthold Stoeger wrote:
> Hi Linus,
>
> On Thursday, 30 August 2018 18:08:41 CEST Linus Torvalds wrote:
> > And I wonder why "Select all" (at least when using the keyboard
> > shortcut) changes the currently shown dive. That seems bogus too.
>
> I think this is caused by select_dive():
> selected_dive = idx;
> Note that selected_dive is the index of the "current dive". And it seems to
> have been like that for ages.
If you change that to
if (selected_dive < 0)
selected_dive = idx;
CTRL-a will not change the current dive. On the flip side, changing the
selection with SHIFT-up and SHIFT-down will not change the current dive
either, which is an unexpected behavior. Therefore, we should keep this in
mind, but perhaps wait until I'm finished with the divelist thing.
Berthold
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
