On 15 September 2018 at 01:48, Bill Perry <[email protected]> wrote:
> Yes, I can do PR. (once I figure out how to do signing)
feel free to ask any github related questions, if any.
> but I don't understand:
>
>> sleeping for small chunks of time can end up being better.
>
> The modification I did used the exact same constant 1ms sleep after each
> ftdi_read_data() call that the current code does but it checked elapsed time
> prior each 1ms sleep
> rather than counting the number of 1ms sleeps until they equaled the desired
> millisecond timeout.
> Counting the number of 1ms sleeps done does not work since it does account for
> the time inside the loop (which can be significant like 100+ ms) since
> sometimes the ftdi_read_data() doesn't return immediately
> when there is no data.
> That is why looking at elapsed time is required.
>
> Are you wanting something smarter than changing the way the loop exits by
> checking elapsed time instead of blindly looping {timout} times?
>
ah, i misunderstood the initial comment, sorry.
i'd encourage you to send the PR so that we can have a look at the
code and discuss it.
thanks
lubomir
--
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
