Hi Linus, On Sunday, 23 September 2018 00:17:38 CEST Linus Torvalds wrote: > On Sat, Sep 22, 2018 at 2:35 PM Linus Torvalds > > <torva...@linux-foundation.org> wrote: > > But it's basically unfixable as it is now. As long as a "struct dive" > > contains that broken "uint32_t dive_site_uuid;" as the dive site > > descriptor, we *have* to create the dive site this way. > > Side note: one possible solution is to get rid of that dive_site_uuid, > and replace it with a "struct divesite *ds" instead.
This is actually on my TODO-list, notably when making import-dives undo-able. Just like on undo/redo of add-dives we have to remove/add implicitly generated dive-trips, on undo/redo of import-dives we'll have to remove/add new dive- sites. I don't see the UI part as a problem. Doing away with the "uniq-id" of dives on desktop was quite easy and I think the same is true for dive-site uuids. Not sure you want to wait that long, though. Berthold _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
