On Sun, 30 Sep 2018 at 00:47, Lubomir I. Ivanov <[email protected]> wrote: > > On Sun, 30 Sep 2018 at 00:43, Dirk Hohndel <[email protected]> wrote: > > > > > > > On Sep 29, 2018, at 2:29 PM, Lubomir I. Ivanov <[email protected]> > > > wrote: > > >> > > >> Subsurface v4.8.2-74-g110fbbf7dbb3, > > >> built with libdivecomputer v0.7.0 > > >> built with Qt Version 5.9.5, runtime from Qt Version 5.10.1 > > > > So these tests are still with an older binary. Would it make sense > > to start testing with newer binaries? > > > > http://subsurface-divelog.org/downloads/test/WINBLE-subsurface-4.8.3-6-g4486c66f498a.exe > > > > I tried to enable the BLE discovery logging, but that didn't quite work, it > > seems. > > You mentioned that this needs a debug build (which doesn't appear to be the > > case on other OSs)... > > so this will need more tinkering :-/ > > > > i'm seeing one problem with our source code. this should be wrapped in: > > #if !defined(Q_OS_WIN) > ... > #endif > > https://github.com/Subsurface-divelog/subsurface/blob/master/core/qt-ble.cpp#L408-L409 > > random addresses should not be used on Win32. >
but it feels like the function is a NOP on Windows, we need to test if that's the case by disabling it: http://doc.qt.io/qt-5/qlowenergycontroller.html#setRemoteAddressType lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
