On 6/28/19 3:48 AM, Dirk Hohndel wrote:
No, this is all on the Mac.
I'm seeing this on Mobile.
I'm running on the beta channel - 2.1.6(4.8.4.577) on Android and
downloading from Shearwater Perdix over Bluetooth LE.
I see the same issue Dirk reported - that each new download imports the
dives into a new trip, rather than adding them to the existing trip. It
does this whether it's an additional dive on the same day, or the next
day - really no matter what.
However, this is not happening for my wife, who is running
2.1.6(4.8.4.66) using mobile on Android and downloading from Shearwater
Perdix over Bluetooth LE. For her, new dives are correctly being added
to the existing trip.
On June 28, 2019 1:56:08 PM GMT+09:00, Berthold Stoeger
<[email protected]> wrote:
Hi Dirk,
On Friday, 28 June 2019 06:00:44 CEST Dirk Hohndel wrote:
Every time I download a new dive from my dive computer,
Subsurface creates a
new trip for the downloaded dive instead of adding the dive to
the existing
dive trip.
Miika reported the same problem.
Reading the code I can see that we have two very different paths for
"addDive":
DiveListBase::addDive() which is called when importing from a
dive computer
- which doesn't even try to match the dive to an existing trip
AddDive::addDive() which appears to do the right thing, but
creates an undo
event per dive that's added (which isn't what we want for the
import).
Dive import on desktop works via Command::importDives(). Whether a new trip
is
generated is controlled with the IMPORT_ADD_TO_NEW_TRIP flag. See desktop-
widgets/downloadfromdivecomputer.cpp.
I reckon that you download with your phone? I can try to switch that to
Command::importDives() but I think I would have to do this "blind", i.e.
without the possibility to test. If I remember correctly, BT does not work
on
my mobile-on-desktop version.
Berthold
--
From my phone
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
