On Wednesday, 17 July 2019 23:20:29 CEST Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 9:53 PM Steve <[email protected]> wrote: > > Applied the patach and got: Unknown cylinder use string 'Freedive' > > Ok, that should never be valid, and shouldn't be a possible value. It > does sound like there's been corruption at some point, although I > can't see how _that_ kind of corruption ever happened.
Yes, something fishy is going on. I think your patch should go into 4.9 so that we never have an invalid -1 as cylinder_use since that also could lead to crashes when displaying the dive. On the flip side, it does hide a corruption. Would you mind if I make a PR out of your patch? I'm not sure how to handle authorship, though. Berthold _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
