Yeah, I saw the parameter and an using it locally, but as Dirk mentions it isn't used by the build on GitHub. I will include this in my changes when I get something that behaves.
On Wed, 27 May 2020, 20:00 Dirk Hohndel, <[email protected]> wrote: > Hi Salva, > > you are of course correct. And I had used a script to pass that in here, > but then never checked in that script. > As a result the GitHub Action happened to use 'master' - which wasn't > really what I had intended. > > /D > > On May 27, 2020, at 10:52 AM, Salvador Cuñat <[email protected]> > wrote: > > Hi Dirk, Paul > > El mar., 26 may. 2020 17:30, Dirk Hohndel via subsurface < > [email protected]> escribió: > >> >> The MXE version is fixed as a specific SHA. And as I grep through the >> sources to refresh my memory where that's done I notice that the SHA >> doesn't appear to be in the source tree. How weird. >> I believe the last one that I used (based on the remnants of local >> builds) was 9f6b9c6f - but I need to dig some more to figure out why this >> isn't in the sources... >> > > In aab658f we introduced a parameter for the docker build to pass the mxe > git sha using --build-arg= > > After this change the used version is not in the Dockerfile any more, but > it's manually entered while building the image. > > Best regards. > > Salva. > > >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
