On Sat, 10 Oct 2020, Dirk Hohndel via subsurface wrote:
> > On Oct 10, 2020, at 1:55 AM, Cristian Ionescu-Idbohrn via subsurface
> > <subsurface@subsurface-divelog.org> wrote:
> >
> > Anyone else experiences this? Does this have anything to do with the
> > recent effort to "remove Grantlee references"? It would seem so, as
> > the code builds on commit b3f5473b66b8210d1276f197876e0e2d7bbd6fa7.
> >
> > The error message is:
> >
> > .../subsurface/desktop-widgets/mainwindow.cpp:59:10: fatal error:
> > QPrintDialog: No such file or directory
> > 59 | #include <QPrintDialog>
> > | ^~~~~~~~~~~~~~
> > compilation terminated.
> > make[2]: ***
> > [desktop-widgets/CMakeFiles/subsurface_interface.dir/build.make:477:
> > desktop-widgets/CMakeFiles/subsurface_interface.dir/mainwindow.cpp.o] Error
> > 1
> >
> > Both QPrintDialog and qprintdialog.h files exist and belong to package
> > qtbase5-dev (version 5.14.2+dfsg-6, debian unstable):
> >
> > $ ls -l
> > /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport/{QPrintDialog,qprintdialog.h}
> > -rw-r--r-- 1 root root 26 Mar 27 2020
> > /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport/QPrintDialog
> > -rw-r--r-- 1 root root 3589 Mar 27 2020
> > /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport/qprintdialog.h
> >
> > and it appears they have been there for a while, or moved there from
> > elsewhere.
>
>
> This is indeed a result of the recent removal of Grantlee and then
> not rerunning cmake.
> In theory that should happen automatically through Makefile
> dependency, but my guess is something went wrong there for you ;-)
>
> Can you remove your build directory and start again running
> subsurface/scripts/build.sh from the directory 'above' the
> subsurface directory?
> All the tests passed, but they of course always build from
> scratch...
Thing is I got the same result after cleaning up my build tree as
after cloning a brand new one. As said, backing to commit
b3f5473b66b8210d1276f197876e0e2d7bbd6fa7 solved the problem.
Cheers,
--
Cristian
_______________________________________________
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
