Good stuff Robert. Thank you. Kind regards, willem. On Sun, 31 Oct 2021, 19:01 Lubomir I. Ivanov via subsurface, < [email protected]> wrote:
> On Sun, 31 Oct 2021 at 17:12, Robert Helling <[email protected]> wrote: > > > > HI everybody, > > > > I wanted to report on my progress in replacing Subsurface’s use of > WebKit by WebEngine. I had already done this in the part of the user > manual, but as this transition was only fragmentary at the time the > corresponding code was removed at a later point. > > > > So I reinserted it and also made quite some progress on the printing > part. So much that I want to share it with you at this point. You can find > it at > > > > https://github.com/atdotde/subsurface/tree/webengineagain > > > > I removed a lot of code originally contributed by Gehad ElRobey as a > GSoC student in 2015 but what I have now appears to be a lot simpler to me. > > > > It still requires some cleaning up and there are a few things to fix. > Specifically, at the moment, the print preview is broken and there is a > mysterious empty page at the end of the print out. But I think the bulk of > the work is done and it is time more eyes should have a look. I particular > I would like to hear from Lubomir as he was the project’s mentor at the > time IIRC. > > > > hi Robert. > > thank you for working on this. > it was discussed in the past that the WebEngine change has to happen > eventually, but i think i recall blockers outside of the usage in > printing and user manual - e.g. build process, distribution? > could be wrong, not remembering correctly. if that is not longer the > case, great... > > overall, if the printing "stack" port is one-to-one with the old code > and we are not introducing user visible regressions this seems fine. > if you send a PR broken into relevant commits i can try to find time > for review, but likely only code review, without building and testing > locally. > > lubomir > -- > _______________________________________________ > subsurface mailing list > [email protected] > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
