On Freitag, 3. Dezember 2021 23:12:39 CET Linus Torvalds via subsurface wrote: > On Fri, Dec 3, 2021 at 1:48 PM Alan Brown via subsurface > > <[email protected]> wrote: > > Thanks for looking into this. The test still fails but the number of > > lines in the diffs are fewer. > > Still seems to be that EAD line if I count the columns right. > > We do have a few places where we end up converting to an integer > value, only to then convert back to a floating point.
Yes, in particular Robert's new code reads as entry->ead = mbar_to_depth(depth_to_mbar(entry->depth, dive) ...); depth_to_mbar() returns an int, and 1 bar is 10 m, thus 1 mbar is 10 mm which is precisely the observed difference, no? The whole thing is a bit of a mess. Berthold _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
