Hi Linus,
On Sonntag, 3. April 2022 00:30:39 CEST Linus Torvalds wrote:
> That default flag was added by commit b6f821886 ("mobile: unify
> download code on mobile and desktop"), but as far as I can tell, it
> acted that way even before (it used to do
>
> add_imported_dives(&tables.first, nullptr, &tables.second,
> IMPORT_PREFER_IMPORTED | IMPORT_IS_DOWNLOADED);
>
> in the qt-model code before that. And it looked to be true regardless
> of how far back I went.
Your analysis sounds very plausible. This seems to work as intended, or at
least how it worked before.
Generally, I'm not a fan of default parameters and prefer things explicit. In
this case I probably was too lazy to figure out how to get the constants into
QML.
Since I am one of those normies with only one divecomputer and don't use
mobile, I really cannot say what the right thing to do is. My guess would be
implementing switching of the DC on mobile? The profile-code doesn't use the
global dc_number anymore (with one exception that should be fixed), so that
should not be hard.
Berthold
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
