On 10/06/2010 03:23 PM, Simon Schampijer wrote: > On 10/06/2010 03:20 PM, Sascha Silbe wrote: >> Excerpts from simon's message of Wed Oct 06 13:57:20 +0200 2010: >> >>> see as well #2291 for more info. This one is important for 0.90. >> >> A bit more background information would be nice. A one-line summary >> of the analysis in #2291 (i.e. input vs. screen, sub-pixel vs. whole- >> pixel coordinate systems) would suffice. >> Also the summary should be more "active" (e.g. "fix address completion"). >> Please adjust these before pushing. Thanks! >> >> Acked-By: Sascha Silbe<sascha-...@silbe.org> >> >> Sascha > > Thanks for the review. Will address your comments. > > Regards, > Simon
Hmm, Lucian was to quick. Lucian you should leave the ticket number in the comment. Actually, you should probably take it as is unless there is a reason to not do so. 'git-am' will do so for you. http://git.sugarlabs.org/projects/browse/repos/mainline/commits/e8130523d74e24be64362c723a9ebed1087fc521 Btw, the other commits were all intended to go on master and sucrose-0.90? You might want to branch off at this stage [1], if you have things that are not intended to land in 0.90. Regards, Simon http://wiki.sugarlabs.org/go/Development_Team/Release#Branching _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel