On 13 November 2010 11:41,  <shan...@seeta.in> wrote:
> From: Shanjit Singh Jajmann <shan...@seeta.in>
>
> For every existing file copied to the location, the names are explicitly
> changed to filename_copynumber.extension e.g. games_1.png, games_2.png,
> games_3.jpg and so on.
>
> ---
> v1 -> v2. Parenthesis idea removed, i initialised from 1.
> Recommendations by Gonzalo Odiard, James Cameron and Martin Dengler added.

You still missed my point. And anything after "---" gets removed in
the commit message.

My point is that this patch is written by Gonzalo Odiard. You can see
it clearly in this email thread on November 10th.
Therefore the first line of your patch should be:

From: Gonzalo Odiard <gonz...@laptop.org>

It's still OK for you to submit the patch even though you didn't write
it, and Gonzalo would probably even appreciate you taking on the role
of submission, but its important that you put the correct authorship.

Daniel
_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Reply via email to