Team, I tried sending a patch to this thread by following the standard procedure of copying and pasting the message id to the "in-reply-to : ". However, for some reason the patch goes on to the different thread.
Please find the link to the patch, http://patchwork.sugarlabs.org/patch/519/ Shan On Mon, Dec 6, 2010 at 4:36 PM, Shanjit Singh Jajmann <shan...@seeta.in>wrote: > Team, > > I thank you all for having a look at the patch and for recommending > necessary changes. > > I am sending a revised patch for the same. > > Feedback and Response appreciated. > > > Shan > > > On Sat, Nov 13, 2010 at 6:45 PM, Gonzalo Odiard <gonz...@laptop.org>wrote: > >> Reviewed-By: gonz...@laptop.org >> >> >> On Sat, Nov 13, 2010 at 7:08 AM, <shan...@seeta.in> wrote: >> >>> From: Shanjit Singh Jajmann <shan...@seeta.in> >>> >>> Muting by clicking on the icon is killed. >>> --- >>> extensions/deviceicon/speaker.py | 10 ---------- >>> 1 files changed, 0 insertions(+), 10 deletions(-) >>> >>> diff --git a/extensions/deviceicon/speaker.py >>> b/extensions/deviceicon/speaker.py >>> index 3a54464..4242105 100644 >>> --- a/extensions/deviceicon/speaker.py >>> +++ b/extensions/deviceicon/speaker.py >>> @@ -50,9 +50,6 @@ class DeviceView(TrayIcon): >>> >>> self.connect('expose-event', self.__expose_event_cb) >>> >>> - self._icon_widget.connect('button-release-event', >>> - self.__button_release_event_cb) >>> - >>> self._update_info() >>> >>> def create_palette(self): >>> @@ -73,13 +70,6 @@ class DeviceView(TrayIcon): >>> self.icon.props.icon_name = get_icon_state(name, current_level, >>> step=-1) >>> self.icon.props.xo_color = xo_color >>> >>> - def __button_release_event_cb(self, widget, event): >>> - if event.button == 1: >>> - self._model.props.muted = not self._model.props.muted >>> - return True >>> - else: >>> - return False >>> - >>> def __expose_event_cb(self, *args): >>> self._update_info() >>> >>> -- >>> 1.7.2.2 >>> >>> _______________________________________________ >>> Sugar-devel mailing list >>> Sugar-devel@lists.sugarlabs.org >>> http://lists.sugarlabs.org/listinfo/sugar-devel >>> >> >> >
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel