On 10/17/2011 09:36 AM, James Cameron wrote:
On Mon, Oct 17, 2011 at 09:23:18AM +0200, Simon Schampijer wrote:def _parse_firmware_number(firmware_no): if firmware_no is None: firmware_no = _not_available else: # try to extract Open Firmware version from OLPC style # version string, e.g. "CL2 Q4B11 Q4B" fields = re.split(' +', firmware_no) if len(fields) == 3: firmware_no = fields[1] return firmware_noAgain I disagree with this method, since it expects whitespace between fields, and OpenFirmware does not guarantee whitespace. Instead, you should extract byte positions. Skip six characters, then extract seven characters. Trim any trailing spaces from the result. Mitch and I discussed this during this last week.
Ok, I can firmware_no[6:13] but how do you differentiate then with a version number you would get on powerpc like 'OpenFirmware 3'?
Regards, Simon _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
