On 05/21/2012 06:15 PM, Manuel Quiñones wrote:
This patch moves the line that sets the title to the filename of the PDF, so we display "Loading..." until we know the title, and if title is None, we show the filename.Signed-off-by: Manuel Quiñones<ma...@laptop.org> --- pdfviewer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pdfviewer.py b/pdfviewer.py index ef6a6ea..cf435d6 100644 --- a/pdfviewer.py +++ b/pdfviewer.py @@ -289,8 +289,6 @@ class PDFTabPage(Gtk.HBox): # The title may be given from the Journal: if title is not None: self._browser.props.title = title - else: - self._browser.props.title = os.path.basename(requested_uri) self._browser.props.uri = requested_uri self._browser.props.load_status = WebKit.LoadStatus.PROVISIONAL @@ -335,6 +333,8 @@ class PDFTabPage(Gtk.HBox): pdf_title = self._evince_viewer.get_pdf_title() if pdf_title is not None: self._browser.props.title = pdf_title + else: + self._browser.props.title = os.path.basename(self._requested_uri) def _get_path_from_journal(self, journal_uri): """Get the system tree URI of the file for the Journal object."""
That one looks good as well, please push. Now only http://bugs.sugarlabs.org/ticket/3620 is left in this area! :) Regards, Simon _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
