On 08/21/2012 03:48 PM, Gary Martin wrote:
On 21 Aug 2012, at 13:34, Simon Schampijer <[email protected]> wrote:On 08/21/2012 01:57 PM, Gary Martin wrote:Hi Simon, On 21 Aug 2012, at 05:17, Simon Schampijer <[email protected]> wrote:On 08/20/2012 11:21 PM, Manuel Quiñones wrote:2012/8/19 Simon Schampijer <[email protected]>:Hi, I have been working on the confirmation alert for the Journal, submitted a patch [1]. "Erasing an entry in the Journal does not ask for confirmation before doing the erase. This patch adds an alert to the ListView and the DetailView that asks for confirmation before doing the erase. This is part of the touch interaction work [2]". I think the need is clear, I just want to confirm the wording of the message and title."This will erase the object..." can also work, but I think "This will erase the entry..." works better.About the alert for the duplication. I am not 100% convinced it is needed.+1 to not add an alert in duplication too.There is not much harm in duplicating an entry (unless it is really big). I try to avoid confirmation alerts when possible. I think the only thing which is critical is feedback in that case. In the ListView the feedback is given. Duplicating an entry in the DetailView lacks a bit the feedback what has happened. Long term an animation would be nice here. Short term options that would help giving feedback here (please not an alert:)?What about a message "duplicating entry..." that dissapears in a few seconds? Yes, is an alert :) but without Accept/Cancel buttons.Yes, I thought about that as well, actually. In the ListView I think feedback is great, in the DetailView not so much, so the alert would be only in the DetailView?Apologies not to be clear enough, but for both cases (Erase and Duplicate), the confirmation dialogues were intended only for the detail view where the toolbar button icon functions may not be immediately obvious and their resulting action not clear (Duplicate) or undoable (Erase). No need for the dialogues in the main Journal list view as you have to explicitly raise an entries palette and then select the Erase or Duplicate item from those options presented (text and small icon). Regards, --GaryControversial part: Ok, maybe I did misunderstand or maybe did want to :) It is true that the erase option is in a Palette, so revealing the Palette is not as easy to be triggered by mistake. But maybe you have fat fingers and 'while wanting choose the option to show the details of that entry' you hit erase by accident - I think I would still play safe here and have a confirmation alert before erasing an item in the ListView.OK. With the intention to land the multi-select Journal batch feature that covers the case where you might need to tidy up and remove more than a few entries in an efficient manor (just one Dialogue to get past).Clear part: Ok, so let's do the alerts in the detail view. Can you set on the wording for both. We need a title and a message.So for reference, the Activity home list view has a (in my opinion a rather wordy) Erase confirmation dialogue: Confirm erase Confirm erase: Do you want to permanently erase <activity_name>? ((x) Keep ((√) Erase) And Ajay, in his multi-select Journal batch patch, currently has: Erase Do you want to erase N entries? ((x) Stop) ((√) Continue) I'd propose for both the Journal list & detail views: Erase Do you want to permanently erase <entry name>? ((x) Cancel ((√) Erase)
That looks good, as discussed on irc the entry name should be in quotes. I have attached a screenshot.
For the Journal detail view: Duplicate Do you want to duplicate <entry name>? ((x) Cancel ((√) Duplicate) Ajay, if folks are happy with the above, could we tweak the dialogue strings in your multi-select patch to match: Erase Do you want to permanently erase N entries? ((x) Cancel ((√) Erase) Copy Do you want to copy N entries to <target>? ((x) Cancel ((√) Copy) Simon, if (!) folks agree with above, the Activity home list view dialogue text could be tided up to for consistency ;)
Yes, sounds good with me.@Chris, are you happy if we change the activity erase string for consistency reasons?
Regards, Simon
<<attachment: erase_list.png>>
_______________________________________________ Sugar-devel mailing list [email protected] http://lists.sugarlabs.org/listinfo/sugar-devel
