Yeah, the get_block_text way is nicer. --scott On Feb 4, 2013 10:39 AM, "Gonzalo Odiard" <godi...@gmail.com> wrote:
> I have read the patches. > The only one I don't like too much is the last one. > I prefer doing like in dataretriever.py > > > https://github.com/cscott/wikiserver/blob/50446f21436c936f0aea3884401fc6cd1e8ae5d6/dataretriever.py#L179 > > I know, there are a few places with code duplication, I need improve that. > > Gonzalo > > > On Sun, Feb 3, 2013 at 11:33 PM, Gonzalo Odiard <godi...@gmail.com> wrote: > >> Thanks! >> I don't know if I will have time this week, but will look at this and >> integrate the changes. >> >> Gonzalo >> >> >> On Sun, Feb 3, 2013 at 5:25 PM, C. Scott Ananian <csc...@laptop.org>wrote: >> >>> I did quite a bit of work on the Wikipedia activity this weekend >>> (related to an HTML port I was working on). I've pushed a set of patches >>> to: >>> https://github.com/cscott/wikiserver >>> based on the latest version at >>> ssh://dev.laptop.org/git/projects/wikiserver >>> >>> Full list of patches is at the end of this email. The summary: I >>> updated mwlib (used to generate HTML from mediawiki markup) from 0.6.2 to >>> 0.8.5 to fix issues I had with infinite-loops in template rendering in the >>> full simple English wikipedia. In the process we got the latest full >>> complete list of translations for Image/Media/Template etc so greatly >>> broadened the # of languages the Wikipedia activity will work with. >>> >>> I also fixed a bug with #anchors in article titles which was causing >>> multiple copies of the articles to be added to the database. This should >>> decrease the size of the database for all languages. Another bug squashed >>> involved different articles with the names differing only in case, for >>> example Template:TOCright and Template:tocright. And there were some SQL >>> escaping issues with article titles which contain quotation marks. >>> >>> There were also some fixes to prevent the processing scripts from >>> breaking when their output is redirected to a file (by default console uses >>> utf-8 encoding, file uses ascii encoding, sigh). >>> >>> Review, comment, merge if you can, enjoy! >>> --scott >>> >>> Full list of patches: >>> f35f8b4c10fb6cddfb48af32ef1cc65f4d40fee2 Use smaller bzip2 block size to >>> improve decompression time. >>> efdf324952e30260596a6a2092be5d59559c8e4c Update to mwlib 0.8.5. >>> 2773b52fa988a6c456f879a470e400eb87e060d2 Update mwlib to 0.8.4. >>> 490c092afff6b6c697252f399b3ce3c3ad0b1cc3 Update mwlib to 0.8.3. >>> e0002405fda01b4a29fde0436d058d75ee7ca8db Update mwlib to 0.8.2. >>> 9da2774ebdadd81484e29144856f0798df08b505 Update mwlib to 0.8.1. >>> ceae189e3dc1631d5157c0c9335803521485276b Update list of localized >>> namespaces to that in mediawiki 1.20.2. >>> d4d4c636dcf154a6c05874410d848a353ffd5f7b Update to copy of >>> namespace_langs from mwlib 0.11.2. >>> 3beec2ad23a8a5e3aa48197f968035ce16ec9e6e Update mwlib to 0.8.0. >>> f2bca19b4d27a53ff5fe6e7f4f231f182b64c7eb Update mwlib to 0.7.1. >>> 8bb74a6c4f4f3f919171759d9c9a042d0b96aba0 Update mwlib to 0.7.0. >>> c1d765f8638add17b582b41e1f970945fc86da73 Update mwlib to 0.6.2. >>> 86e5bd672b2a23c2b38321e3ee502b7d1219c1a6 Trim #anchor from links to >>> avoid putting multiple copies of articles in db. >>> 47642fe412d0e687995956f0c33abb1663d3078e Don't break if we redirect the >>> output of make_selection.py. >>> bbb9892d7e77a7568b70edb82e4d06a4b30e2b16 Make expandtemplates.py script >>> work even when processing --all articles. >>> d7ddf77f555d9a67a3b19b7bbafb6700814f9213 Make normalize_title >>> consistent; don't squash case-sensitivity. >>> 48153400296aea2c048a4c23f8fe2ac733a088cd Fix RedirectParser and make it >>> the same in the 3 places it is duplicated. >>> 6ba73792e5560d813075f313f8c1fe3443a5e0af Fix SQL escaping issues. >>> >>> -- >>> ( http://cscott.net ) >> >> >> >> >> -- >> Gonzalo Odiard >> >> > > > -- > Gonzalo Odiard > >
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel