2014-03-27 15:23 GMT-03:00 Gonzalo Odiard <godi...@sugarlabs.org>: > Maybe have sense save the spent time as a list too, > like we do with launch times. > Looks like a non invasive change, and a good source of information.
Good point, is the other option I was handling. Is a trivial patch too: https://github.com/manuq/sugar-toolkit-gtk3/pull/8/files I think this one is definetely better. I was in doubt for two reasons: 1. because unlike launch_time, this spent-times metadata will not be saved if the activity does not end properly: could be a crash, a programming error, end of battery, etc. So the item N of spent-times will not necessarily correspont to item N of launch-times. And secondly, because the simpler option satisfies the placeholder that is currently in Harvest https://github.com/tchx84/harvest-server/blob/master/sql/001-harvest.sql#L24 The second one will require a new table in Harvest. But that's an easy change too. Side note: I see we have a horrible mix of styles in metadata, some names use underscore (title_set_by_user, activity_id) and some use minus character (share-scope, icon-color, launch-times). Does anyone know the preferred style? Thanks for the comments. -- .. manuq .. _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
