@James, I'll surely implement those fixes you listed above before sending in a
PR. :)
@everybody I added a new (progresstoolbutton.py) file to "sugar-toolkit-gtk3/
src/graphics/" and did some changes to "browse/"(webtoolbar.py and
downloadmanager.py) files. Shall I send a PR to each repository (browse and
sugar-toolkit-gtk3) individually or shall I send a single PR to "sugar-build"
repo ?
thanks,
Utkarsh Tiwari
On Mon, Feb 22, 2016 at 2:27 PM, James Cameron <[1]qu...@laptop.org> wrote:
The tooltip shows 0.0 with an empty outline just after it shows 1.0
and full icon.
Could this be changed slightly; continue to show 1.0 and full until
the Download Completed question is answered?
On Mon, Feb 22, 2016 at 08:44:25AM +0000, Sam P. wrote:
> This looks great! Please send a patch and we can review it!
>
> On Sun, Feb 21, 2016, 05:29 Utkarsh Tiwari <[1][2]
iamutkarshtiw...@gmail.com>
> wrote:
>
> Hello everyone,
> I finally managed to pull through 50% of
the
> downloadManagerIcon integration task. Here is the gif of all what I
did
> till now -> [2][3]http://imgur.com/zS0W9dG
> There is still a long way to go. Reviews on this would be helpful :)
>
> regards,
> Utkarsh Tiwari
>
>
>
> On Sat, Feb 13, 2016 at 8:36 PM, Utkarsh Tiwari <[3]
> [4]iamutkarshtiw...@gmail.com> wrote:
>
> I need to update a toolbutton in webtoolbar as the download
progresses
> in background. Could anyone please guide me how to go about it?
>
> On 2/11/16, Utkarsh Tiwari <[4][5]iamutkarshtiw...@gmail.com>
wrote:
> > @James As mentioned, I tried making a blend of 'progressIcon' &
> > 'ToolButton' by making some changes to the SugarToolButton
code. Here
> is
> > how the download ProgressIcon @50% completion looks like ->
> > [5][6]http://imgur.com/iBg4Ktr
> >
> > Waiting for your reviews :)
> >
> > On Thu, Feb 11, 2016 at 3:28 PM, Sam P. <sam@sam.today> wrote:
> >
> >> Hello,
> >>
> >> I believe that it passes all the key word and normal arguments
to
> the
> >> superclass constructors.
> >>
> >> Out of interest, why are you using a Gtk drawing area as an
> additional
> >> base class? Every widget (even the tool button) has the draw
> signal. Is
> >> this what you are using it for or is there something else?
> >>
> >> Thanks,
> >> Sam
> >>
> >> On Thu, Feb 11, 2016, 09:03 Utkarsh Tiwari <[6]
> [7]iamutkarshtiw...@gmail.com>
> >> wrote:
> >>
> >>> What does the line "GObject.GObject.__init__(self, **kwargs)"
> exactly
> >>> does in the following gist?
> >>>
> >>> [7][8]https://gist.github.com/iamutkarshtiwari/
5024762d0e8924b52085
> >>>
> >>> On Thu, Feb 4, 2016 at 5:00 AM, James Cameron <[8][9]
qu...@laptop.org>
> wrote:
> >>>
> >>>> Thanks. Yes, the position is as I described.
> >>>>
> >>>> Your question puzzles me. I didn't think there was any
ambiguity
> or
> >>>> doubt. It is unfortunate that I'm the only one who has
posted
> about
> >>>> the positioning of this design change.
> >>>>
> >>>> Is it because you have an alternate suggestion?
> >>>>
> >>>> Good to hear combining the widgets worked. Looking forward
to
> seeing
> >>>> a patch or pull request.
> >>>>
> >>>> On Thu, Feb 04, 2016 at 03:49:54AM +0530, Utkarsh Tiwari
wrote:
> >>>> > @James Is this the icon position you were talking about as
shown
> in
> >>>> > the
> >>>> > attachment below? Your hint for using ProgressIcon
alongwith
> >>>> Toolbutton worked!
> >>>> > ;)
> >>>> >
> >>>> > On Tue, Feb 2, 2016 at 2:17 AM, James Cameron <[1][9]
> [10]qu...@laptop.org>
> >>>> wrote:
> >>>> >
> >>>> > A ToolButton normally has an Icon.
> >>>> >
> >>>> > Instead of the Icon, assign the ProgressIcon?
> >>>> >
> >>>> > As nobody else may have done this, you may need to
find and
> fix
> >>>> > any
> >>>> > bugs in ProgressIcon or ToolButton that prevent it.
> >>>> >
> >>>> > On Mon, Feb 01, 2016 at 11:31:28PM +0530, Utkarsh
Tiwari
> wrote:
> >>>> > > Is there any way to use a ProgressIcon as a
Toolbutton ?
> >>>> > >
> >>>> > > On 2/1/16, Sam P. <sam@sam.today> wrote:
> >>>> > > > Hello!
> >>>> > > >
> >>>> > > > Maybe just a large down arrow and fill it
vertically?
> See
> >>>> > > > 'emblem-downloads' or 'transfer-from' in
sugar-artwork.
> >>>> > > >
> >>>> > > > Thanks,
> >>>> > > > Sam
> >>>> > > >
> >>>> > > >
> >>>> > > > On Mon, Feb 1, 2016 at 9:15 AM, Utkarsh Tiwari
<[2]
> >>>> > [10][11]iamutkarshtiw...@gmail.com>
> >>>> > > > wrote:
> >>>> > > >
> >>>> > > >> How should the Icon for "Download Button" look
like?
> Could
> >>>> you please
> >>>> > > >> provide me some artwork for reference. ?
> >>>> > > >>
> >>>> > > >> On 2/1/16, Utkarsh Tiwari <[3][11]
> [12]iamutkarshtiw...@gmail.com>
> >>>> wrote:
> >>>> > > >> > Omg! I have been looking all over internet on
how to
> >>>> integrate a
> >>>> > > >> > Gtk.ProgressBar into Gtk.Toolbutton and I even
tried
> using
> >>>> > > >> > Gtk.CssProvider styler to scale down the
progressbar
> to a
> >>>> button :D
> >>>> > > >> > Now that(ProgressIcon.py) sounds really cool!
> >>>> > > >> >
> >>>> > > >> > Thank you :) You made my work a bit easier ;)
> >>>> > > >> >
> >>>> > > >> > On 2/1/16, James Cameron <[4][12][13]
qu...@laptop.org>
> wrote:
> >>>> > > >> >> ProgressBar from Gtk is overkill, we already
have a
> >>>> ProgressIcon
> >>>> > > >> >> in Sugar.
> >>>> > > >> >>
> >>>> > > >> >> In sugar-toolkit-gtk3:
> >>>> > > >> >>
> >>>> > > >> >> Look at progressicon.py, you will see it does
not
> use a
> >>>> > ProgressBar,
> >>>> > > >> >> but has a __draw_cb method connected to the
"draw"
> >>>> > signal.
> >>>> > > >> >>
> >>>> > > >> >> Look at toolbutton.py, you will see it wraps
> ToolButton
> >>>> do_draw
> >>>> > > >> >> method.
> >>>> > > >> >>
> >>>> > > >> >> On Mon, Feb 01, 2016 at 12:10:25AM +0530,
Utkarsh
> Tiwari
> >>>> wrote:
> >>>> > > >> >>> "The button to be a blend of ProgressIcon and
> >>>> ToolButton". How to
> >>>> > > >> >>> convert a Gtk.ProgressBar to a Browse
ToolButton?
> >>>> > > >> >>>
> >>>> > > >> >>> On 1/27/16, James Cameron <[5][13][14]
qu...@laptop.org>
> wrote:
> >>>> > > >> >>> > No.
> >>>> > > >> >>> >
> >>>> > > >> >>> > The position marked by your cursor seems to
be
> inside
> >>>> the URL
> >>>> > entry
> >>>> > > >> >>> > box.
> >>>> > > >> >>> >
> >>>> > > >> >>> > I said between the URL entry box and the
back
> button.
> >>>> > > >> >>> >
> >>>> > > >> >>> > Review the Browse source code that defines
these
> >>>> objects.
> >>>> > > >> >>> >
> >>>> > > >> >>> > On Wed, Jan 27, 2016 at 11:39:03AM +0530,
Utkarsh
> >>>> Tiwari wrote:
> >>>> > > >> >>> >> Is this the exact expected location you
were
> talking
> >>>> about the
> >>>> > > >> >>> >> 'download button' as shown in the
screenshot
> below?
> >>>> > > >> >>> >>
> >>>> > > >> >>> >> [6][14][15]http://imgur.com/T0hirTZ
> >>>> > > >> >>> >>
> >>>> > > >> >>> >> On 1/27/16, James Cameron <[7][15]
> [16]qu...@laptop.org>
> >>>> > wrote:
> >>>> > > >> >>> >> > Thanks for working on this.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > Our Sugar human interface guidelines and
> existing
> >>>> code base
> >>>> > > >> >>> >> > don't
> >>>> > > >> >>> >> > have
> >>>> > > >> >>> >> > decorated floating windows or window
> management.
> >>>> Your
> >>>> > proposal
> >>>> > > >> >>> >> > would
> >>>> > > >> >>> >> > not scale to multiple downloads.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > You might ask for design suggestions on
this
> >>>> > mailing
> >>>> list.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > I've resisted making design suggestions
on
> this
> >>>> problem
> >>>> > because
> >>>> > > >> >>> >> > I
> >>>> > > >> >>> >> > don't want to constrain the good ideas
that
> may
> >>>> > come
> >>>> up.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > To get the design conversation started
...
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > When the first download begins, show a
button
> at
> >>>> > the
> >>>> top
> >>>> > between
> >>>> > > >> >>> >> > the
> >>>> > > >> >>> >> > URL entry box and the back button.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > The button to be a blend of ProgressIcon
and
> >>>> ToolButton, with
> >>>> > > >> >>> >> > the
> >>>> > > >> >>> >> > progress fill to show average progress
of all
> >>>> downloads.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > When the button is pressed a download
tab is
> to be
> >>>> shown in
> >>>> > the
> >>>> > > >> >>> >> > canvas, which lists downloads and
progress.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > The download tab can be closed like any
other
> tab.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > The button is to be be hidden before any
> downloads
> >>>> are
> >>>> > started,
> >>>> > > >> >>> >> > shown
> >>>> > > >> >>> >> > on start of first download, and only
hidden if
> the
> >>>> download
> >>>> > tab
> >>>> > > >> >>> >> > is
> >>>> > > >> >>> >> > closed when there are no downloads still
> active.
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > On Tue, Jan 26, 2016 at 06:08:32PM
+0530,
> Utkarsh
> >>>> Tiwari
> >>>> > wrote:
> >>>> > > >> >>> >> >> Hi,
> >>>> > > >> >>> >> >>
> >>>> > > >> >>> >> >> I am trying to integrate the
"Download
> >>>> ProgressBar" in
> >>>> > the
> >>>> > > >> >>> >> >> download
> >>>> > > >> >>> >> >> manager. Here is the screenshot of the
> prototype
> >>>> > on
> >>>> which I
> >>>> > am
> >>>> > > >> >>> >> >> currently
> >>>> > > >> >>> >> >> working -> [1][8][16][17]http://
imgur.com/WUJL8eX
> >>>> > > >> >>> >> >>
> >>>> > > >> >>> >> >> Since the download progress bar is
popping
> over
> >>>> > the
> >>>> browse
> >>>> > > >> >>> >> >> activity,
> >>>> > > >> >>> >> >> is
> >>>> > > >> >>> >> >> it
> >>>> > > >> >>> >> >> feasible?
> >>>> > > >> >>> >> >>
> >>>> > > >> >>> >> >> regards,
> >>>> > > >> >>> >> >> Utkarsh Tiwari
> >>>> > > >> >>> >> >>
> >>>> > > >> >>> >> >> References:
> >>>> > > >> >>> >> >>
> >>>> > > >> >>> >> >> [1] [9][17][18]http://imgur.com/WUJL8eX
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> >>
> _______________________________________________
> >>>> > > >> >>> >> >> Sugar-devel mailing list
> >>>> > > >> >>> >> >> [10][18][19]
Sugar-devel@lists.sugarlabs.org
> >>>> > > >> >>> >> >>
> >>>> > [11][19][20]http://lists.sugarlabs.org/listinfo/
sugar-devel
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >> > --
> >>>> > > >> >>> >> > James Cameron
> >>>> > > >> >>> >> > [12][20][21]http://quozl.netrek.org/
> >>>> > > >> >>> >> >
> _______________________________________________
> >>>> > > >> >>> >> > Sugar-devel mailing list
> >>>> > > >> >>> >> > [13][21][22]
Sugar-devel@lists.sugarlabs.org
> >>>> > > >> >>> >> > [14][22][23]http://lists.sugarlabs.org/
listinfo/
> sugar-devel
> >>>> > > >> >>> >> >
> >>>> > > >> >>> >
> >>>> > > >> >>> > --
> >>>> > > >> >>> > James Cameron
> >>>> > > >> >>> > [15][23][24]http://quozl.netrek.org/
> >>>> > > >> >>> >
> >>>> > > >> >>
> >>>> > > >> >> --
> >>>> > > >> >> James Cameron
> >>>> > > >> >> [16][24][25]http://quozl.netrek.org/
> >>>> > > >> >>
> >>>> > > >> >
> >>>> > > >> _______________________________________________
> >>>> > > >> Sugar-devel mailing list
> >>>> > > >> [17][25][26]Sugar-devel@lists.sugarlabs.org
> >>>> > > >> [18][26][27]http://lists.sugarlabs.org/listinfo/
sugar-devel
> >>>> > > >>
> >>>> > > >
> >>>> >
> >>>> > --
> >>>> > James Cameron
> >>>> > [19][27][28]http://quozl.netrek.org/
> >>>> >
> >>>> > References:
> >>>> >
> >>>> > [1] mailto:[28][29]qu...@laptop.org
> >>>> > [2] mailto:[29][30]iamutkarshtiw...@gmail.com
> >>>> > [3] mailto:[30][31]iamutkarshtiw...@gmail.com
> >>>> > [4] mailto:[31][32]qu...@laptop.org
> >>>> > [5] mailto:[32][33]qu...@laptop.org
> >>>> > [6] [33][34]http://imgur.com/T0hirTZ
> >>>> > [7] mailto:[34][35]qu...@laptop.org
> >>>> > [8] [35][36]http://imgur.com/WUJL8eX
> >>>> > [9] [36][37]http://imgur.com/WUJL8eX
> >>>> > [10] mailto:[37][38]Sugar-devel@lists.sugarlabs.org
> >>>> > [11] [38][39]http://lists.sugarlabs.org/listinfo/
sugar-devel
> >>>> > [12] [39][40]http://quozl.netrek.org/
> >>>> > [13] mailto:[40][41]Sugar-devel@lists.sugarlabs.org
> >>>> > [14] [41][42]http://lists.sugarlabs.org/listinfo/
sugar-devel
> >>>> > [15] [42][43]http://quozl.netrek.org/
> >>>> > [16] [43][44]http://quozl.netrek.org/
> >>>> > [17] mailto:[44][45]Sugar-devel@lists.sugarlabs.org
> >>>> > [18] [45][46]http://lists.sugarlabs.org/listinfo/
sugar-devel
> >>>> > [19] [46][47]http://quozl.netrek.org/
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> James Cameron
> >>>> [47][48]http://quozl.netrek.org/
> >>>>
> >>>
> >>>
> >
>
> References:
>
> [1] mailto:[49]iamutkarshtiw...@gmail.com
> [2] [50]http://imgur.com/zS0W9dG
> [3] mailto:[51]iamutkarshtiw...@gmail.com
> [4] mailto:[52]iamutkarshtiw...@gmail.com
> [5] [53]http://imgur.com/iBg4Ktr
> [6] mailto:[54]iamutkarshtiw...@gmail.com
> [7] [55]https://gist.github.com/iamutkarshtiwari/5024762d0e8924b52085
> [8] mailto:[56]qu...@laptop.org
> [9] mailto:[57]qu...@laptop.org
> [10] mailto:[58]iamutkarshtiw...@gmail.com
> [11] mailto:[59]iamutkarshtiw...@gmail.com
> [12] mailto:[60]qu...@laptop.org
> [13] mailto:[61]qu...@laptop.org
> [14] [62]http://imgur.com/T0hirTZ
> [15] mailto:[63]qu...@laptop.org
> [16] [64]http://imgur.com/WUJL8eX
> [17] [65]http://imgur.com/WUJL8eX
> [18] mailto:[66]Sugar-devel@lists.sugarlabs.org
> [19] [67]http://lists.sugarlabs.org/listinfo/sugar-devel
> [20] [68]http://quozl.netrek.org/
> [21] mailto:[69]Sugar-devel@lists.sugarlabs.org
> [22] [70]http://lists.sugarlabs.org/listinfo/sugar-devel
> [23] [71]http://quozl.netrek.org/
> [24] [72]http://quozl.netrek.org/
> [25] mailto:[73]Sugar-devel@lists.sugarlabs.org
> [26] [74]http://lists.sugarlabs.org/listinfo/sugar-devel
> [27] [75]http://quozl.netrek.org/
> [28] mailto:[76]qu...@laptop.org
> [29] mailto:[77]iamutkarshtiw...@gmail.com
> [30] mailto:[78]iamutkarshtiw...@gmail.com
> [31] mailto:[79]qu...@laptop.org
> [32] mailto:[80]qu...@laptop.org
> [33] [81]http://imgur.com/T0hirTZ
> [34] mailto:[82]qu...@laptop.org
> [35] [83]http://imgur.com/WUJL8eX
> [36] [84]http://imgur.com/WUJL8eX
> [37] mailto:[85]Sugar-devel@lists.sugarlabs.org
> [38] [86]http://lists.sugarlabs.org/listinfo/sugar-devel
> [39] [87]http://quozl.netrek.org/
> [40] mailto:[88]Sugar-devel@lists.sugarlabs.org
> [41] [89]http://lists.sugarlabs.org/listinfo/sugar-devel
> [42] [90]http://quozl.netrek.org/
> [43] [91]http://quozl.netrek.org/
> [44] mailto:[92]Sugar-devel@lists.sugarlabs.org
> [45] [93]http://lists.sugarlabs.org/listinfo/sugar-devel
> [46] [94]http://quozl.netrek.org/
> [47] [95]http://quozl.netrek.org/
--
James Cameron
[96]http://quozl.netrek.org/
References:
[1] mailto:qu...@laptop.org
[2] mailto:iamutkarshtiw...@gmail.com
[3] http://imgur.com/zS0W9dG
[4] mailto:iamutkarshtiw...@gmail.com
[5] mailto:iamutkarshtiw...@gmail.com
[6] http://imgur.com/iBg4Ktr
[7] mailto:iamutkarshtiw...@gmail.com
[8] https://gist.github.com/iamutkarshtiwari/5024762d0e8924b52085
[9] mailto:qu...@laptop.org
[10] mailto:qu...@laptop.org
[11] mailto:iamutkarshtiw...@gmail.com
[12] mailto:iamutkarshtiw...@gmail.com
[13] mailto:qu...@laptop.org
[14] mailto:qu...@laptop.org
[15] http://imgur.com/T0hirTZ
[16] mailto:qu...@laptop.org
[17] http://imgur.com/WUJL8eX
[18] http://imgur.com/WUJL8eX
[19] mailto:Sugar-devel@lists.sugarlabs.org
[20] http://lists.sugarlabs.org/listinfo/sugar-devel
[21] http://quozl.netrek.org/
[22] mailto:Sugar-devel@lists.sugarlabs.org
[23] http://lists.sugarlabs.org/listinfo/
[24] http://quozl.netrek.org/
[25] http://quozl.netrek.org/
[26] mailto:Sugar-devel@lists.sugarlabs.org
[27] http://lists.sugarlabs.org/listinfo/sugar-devel
[28] http://quozl.netrek.org/
[29] mailto:qu...@laptop.org
[30] mailto:iamutkarshtiw...@gmail.com
[31] mailto:iamutkarshtiw...@gmail.com
[32] mailto:qu...@laptop.org
[33] mailto:qu...@laptop.org
[34] http://imgur.com/T0hirTZ
[35] mailto:qu...@laptop.org
[36] http://imgur.com/WUJL8eX
[37] http://imgur.com/WUJL8eX
[38] mailto:Sugar-devel@lists.sugarlabs.org
[39] http://lists.sugarlabs.org/listinfo/sugar-devel
[40] http://quozl.netrek.org/
[41] mailto:Sugar-devel@lists.sugarlabs.org
[42] http://lists.sugarlabs.org/listinfo/sugar-devel
[43] http://quozl.netrek.org/
[44] http://quozl.netrek.org/
[45] mailto:Sugar-devel@lists.sugarlabs.org
[46] http://lists.sugarlabs.org/listinfo/sugar-devel
[47] http://quozl.netrek.org/
[48] http://quozl.netrek.org/
[49] mailto:iamutkarshtiw...@gmail.com
[50] http://imgur.com/zS0W9dG
[51] mailto:iamutkarshtiw...@gmail.com
[52] mailto:iamutkarshtiw...@gmail.com
[53] http://imgur.com/iBg4Ktr
[54] mailto:iamutkarshtiw...@gmail.com
[55] https://gist.github.com/iamutkarshtiwari/5024762d0e8924b52085
[56] mailto:qu...@laptop.org
[57] mailto:qu...@laptop.org
[58] mailto:iamutkarshtiw...@gmail.com
[59] mailto:iamutkarshtiw...@gmail.com
[60] mailto:qu...@laptop.org
[61] mailto:qu...@laptop.org
[62] http://imgur.com/T0hirTZ
[63] mailto:qu...@laptop.org
[64] http://imgur.com/WUJL8eX
[65] http://imgur.com/WUJL8eX
[66] mailto:Sugar-devel@lists.sugarlabs.org
[67] http://lists.sugarlabs.org/listinfo/sugar-devel
[68] http://quozl.netrek.org/
[69] mailto:Sugar-devel@lists.sugarlabs.org
[70] http://lists.sugarlabs.org/listinfo/sugar-devel
[71] http://quozl.netrek.org/
[72] http://quozl.netrek.org/
[73] mailto:Sugar-devel@lists.sugarlabs.org
[74] http://lists.sugarlabs.org/listinfo/sugar-devel
[75] http://quozl.netrek.org/
[76] mailto:qu...@laptop.org
[77] mailto:iamutkarshtiw...@gmail.com
[78] mailto:iamutkarshtiw...@gmail.com
[79] mailto:qu...@laptop.org
[80] mailto:qu...@laptop.org
[81] http://imgur.com/T0hirTZ
[82] mailto:qu...@laptop.org
[83] http://imgur.com/WUJL8eX
[84] http://imgur.com/WUJL8eX
[85] mailto:Sugar-devel@lists.sugarlabs.org
[86] http://lists.sugarlabs.org/listinfo/sugar-devel
[87] http://quozl.netrek.org/
[88] mailto:Sugar-devel@lists.sugarlabs.org
[89] http://lists.sugarlabs.org/listinfo/sugar-devel
[90] http://quozl.netrek.org/
[91] http://quozl.netrek.org/
[92] mailto:Sugar-devel@lists.sugarlabs.org
[93] http://lists.sugarlabs.org/listinfo/sugar-devel
[94] http://quozl.netrek.org/
[95] http://quozl.netrek.org/
[96] http://quozl.netrek.org/
