I have raised pull request. On Wed, Mar 13, 2019 at 1:54 AM navyasri reddy <navyasrireddy1...@gmail.com> wrote:
> I have changed the readme and pushed to forked repo in my github account. > How do I raise a pull request to original repo. I have seen the docs for > contributing but didn't get it much. > > On Wed, Mar 13, 2019 at 12:15 AM Sumit Srivastava <sumitsrisu...@gmail.com> > wrote: > >> Yes, Jaskirat. The reply all button is a wonderful little thing and poses >> much less friction than new members would otherwise experience. >> >> On Wed, 13 Mar 2019, 12:06 am Jaskirat Singh, <juskirat2...@gmail.com> >> wrote: >> >>> Thanks Sumit, >>> >>> This sounds like a better choice for the people helping new contributors >>> to get started. >>> >>> On Wed, 13 Mar 2019, 12:04 am Sumit Srivastava, <sumitsrisu...@gmail.com> >>> wrote: >>> >>>> Navya, >>>> >>>> Good to see you figuring out the codebase! Check out instructions on >>>> downloading and running musicblocks. It should be present in the >>>> musicblocks documentation. It states: >>>> >>>> "*If you want to run Music Blocks offline, download this repo and >>>> point your browser to the index.html file found in the musicblocks >>>> directory on your local file system."* >>>> >>>> Also, if you post your questions directly to >>>> sugar-devel@lists.sugarlabs.org , more people can come in and >>>> contribute. I am sorry if you had a rough start but rest assured, the >>>> community is awesome! >>>> >>>> I'll be available at sugar-devel mailing list and so would be a lot >>>> other experienced developers in the community. Always better to expose your >>>> questions to more people, right? For this thread, you can use "reply-all" >>>> button on gmail to directly post to sugarlabs devel list and me. >>>> >>>> Keep asking questions! :) >>>> >>>> Regards >>>> Sumit Srivastava >>>> >>>> On Tue, 12 Mar 2019, 11:51 pm navyasri reddy, < >>>> navyasrireddy1...@gmail.com> wrote: >>>> >>>>> Hey, >>>>> Thanks for helping me out with this. I have found through the other >>>>> issues that the sound sample need to have same pitch through out which is >>>>> not mentioned in the readme and also testing whether the sound is added >>>>> properly or not is also not there in the readme. >>>>> I am not sure how to test it. Can you direct me so that i can test and >>>>> update readme. >>>>> >>>>> Thanks. >>>>> >>>>> On Mon, Mar 11, 2019 at 7:08 PM Sumit Srivastava < >>>>> sumitsrisu...@gmail.com> wrote: >>>>> >>>>>> Hi, navyasri! >>>>>> >>>>>> It'd be great if you post publicly to the sugar devel mailing list. >>>>>> While I have no problem with replying to your question privately, the >>>>>> community as a whole benefits more from public discussions like these. >>>>>> >>>>>> Don't worry you can post all kinds of beginner questions, even the >>>>>> one you think might be silly, to the mailing list. :) >>>>>> >>>>>> Here are the steps to approach the issue: >>>>>> >>>>>> -Fork the branch. >>>>>> >>>>>> -Take a look at the instructions to add sample sound. >>>>>> >>>>>> -Try and do it yourself. >>>>>> >>>>>> -Did you find instructions were useful? Do they need to be updated? >>>>>> (Hint: Yes, because of which the issue was created) >>>>>> >>>>>> -Figure out how can you better explain the process you followed to >>>>>> add a sample sound. >>>>>> >>>>>> -Write it down. >>>>>> >>>>>> -Commit to your branch, test, and then request to merge. >>>>>> >>>>>> Regards >>>>>> Sumit Srivastava >>>>>> >>>>>> On Mon, 11 Mar 2019, 2:16 pm navyasri reddy, < >>>>>> navyasrireddy1...@gmail.com> wrote: >>>>>> >>>>>>> Hey, >>>>>>> This is navyasri. I wan to contribute to music blocks by starting >>>>>>> with some basic contribution (below attached). This is about updating >>>>>>> readme but I am not clear with the issue. There's no reply to extra >>>>>>> information on this issue. A help for this would be appreciated. >>>>>>> https://github.com/sugarlabs/musicblocks/issues/1468 >>>>>>> >>>>>>> Thanks, >>>>>>> navyasri >>>>>>> >>>>>> _______________________________________________ >>>> Sugar-devel mailing list >>>> Sugar-devel@lists.sugarlabs.org >>>> http://lists.sugarlabs.org/listinfo/sugar-devel >>>> >>>
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel