I'm not very happy about the favorite stuff in the registry. I'd prefer to have bundle properties associated directly with some kind on Bundle object (not necessarily the one which wraps the on disk description). I'm fine with doing the registry refactoring in the next step though, it's all a bit of a mess.
+ def _calculate_radius_and_icon_size(self, children_count): Can we separate this in two functions? 80 cols... Can you please clarify the goal of the PulsingIcon changes? Also there seem to be a big block of code commented out there and a mix of old/new style gobject properties which is confusing me :) Marco _______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
